From bcd0c566dff49896ad04188010c07a388a9f9693 Mon Sep 17 00:00:00 2001 From: Mitchell Skaggs Date: Mon, 26 Apr 2021 00:08:12 -0500 Subject: [PATCH] Prevent needlessly `escape`ing player names Handlebars already does this, so doing it twice causes issues: https://handlebarsjs.com/guide/expressions.html#html-escaping --- src/viseur/game/game-over-screen/game-over-screen.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/viseur/game/game-over-screen/game-over-screen.ts b/src/viseur/game/game-over-screen/game-over-screen.ts index e3fec95..cf8877b 100644 --- a/src/viseur/game/game-over-screen/game-over-screen.ts +++ b/src/viseur/game/game-over-screen/game-over-screen.ts @@ -1,4 +1,3 @@ -import { escape } from "lodash"; import { partial } from "src/core/partial"; import { BaseElement, BaseElementArgs } from "src/core/ui/base-element"; import { getContrastingColor, Immutable } from "src/utils"; @@ -92,7 +91,7 @@ export class GameOverScreen extends BaseElement { const color = this.game.getPlayersColor(player); const item = { - name: escape(player.name), + name: player.name, wonOrLost: player.won ? "Won" : "Lost", reason: player.won ? player.reasonWon : player.reasonLost, bgColor: color.opaquer(0.375).rgb(),