Skip to content

Review changes link gets added to review comments that were added after PR merge #2369

Description

@fmease

Obviously, once a PR is merged nobody can push any more commits to it. Still, triagebot currently adds a Review changes link to comments that were posted after merge (which isn't uncommon if the PR introduced correctness or performance regressions).

Example: rust-lang/rust#152901 (comment).

I expected triagebot to ignore merged PRs when it comes to "review changes".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions