Enhancement: Add status_reason field to Command message - #7377
Conversation
Signed-off-by: Rucha0901 <imt_2025071@iiitm.ac.in>
✅ Deploy Preview for pipecd-site canceled.
|
|
👋 Hi @Rucha0901, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
There was a problem hiding this comment.
🟡 Changes recommended
Failure reasons are not wired through reporting and command-store updates.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds status_reason to the Command protobuf and regenerates Go and web bindings. The field is not yet propagated through reporting and storage, so failed-command reasons remain empty.
Changes:
- Adds field 23 to
Command. - Regenerates Go protobuf and validation code.
- Regenerates JavaScript and TypeScript bindings.
File summaries
| File | Summary |
|---|---|
web/model/command_pb.js |
Regenerated JavaScript bindings. |
web/model/command_pb.d.ts |
Regenerated TypeScript definitions. |
pkg/model/command.proto |
Adds status_reason. |
pkg/model/command.pb.validate.go |
Regenerated validation code. |
pkg/model/command.pb.go |
Regenerated Go protobuf bindings. |
Review details
Files not reviewed (2)
- pkg/model/command.pb.go: Generated file
- pkg/model/command.pb.validate.go: Generated file
- Files reviewed: 2/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| map<string,string> metadata = 21; | ||
| int64 handled_at = 22 [(validate.rules).int64.gte = 0]; | ||
| // TODO: Add a new field to show why command was failed. | ||
| string status_reason = 23; |
What this PR does:
Adds a status_reason field to the Command protobuf message and regenerates the go code.
Why we need it:
To record the exact reason why a command failed, resolving a TODO in pkg/model/command.proto.
Which issue(s) this PR fixes:
Fixes #7376
Does this PR introduce a user-facing change?:
Screenshots/Videos (for documentation or website changes):
N/A