installer: address review feedback for NetworkDeviceSpec validation

- Reduce nameservers MaxItems from 10 to 3 to match existing Go
  validation that enforces a maximum of 3 nameservers.
- Add unit tests for IPv6 nameserver, invalid nameserver, empty
  gateway, and IPv6 CIDR ipAddrs to cover the XValidation CEL rules.
- Update generated CRD YAML to reflect the MaxItems change.

Signed-off-by: Ankit Mahajan <ankimaha@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Ankit Mahajan <ankimaha@redhat.com>

Author: ankimaha-sys

data/data/install.openshift.io_installconfigs.yaml

@@ -8692,7 +8692,7 @@ spec:
                               example: 8.8.8.8
                               items:
                                 type: string
-                              maxItems: 10
+                              maxItems: 3
                               type: array
                               x-kubernetes-validations:
                               - message: each nameserver must be a valid IPv4 or IPv6

pkg/types/vsphere/platform.go

@@ -348,7 +348,7 @@ type NetworkDeviceSpec struct {
 	// 8.8.8.8. a nameserver is not provided by a fulfilled IPAddressClaim. If DHCP is not the
 	// source of IP addresses for this network device, nameservers should include a valid nameserver.
 	// +kubebuilder:validation:XValidation:rule="self.all(x, isIP(x))",message="each nameserver must be a valid IPv4 or IPv6 address"
-	// +kubebuilder:validation:MaxItems=10
+	// +kubebuilder:validation:MaxItems=3
 	// +kubebuilder:example=`8.8.8.8`
 	Nameservers []string `json:"nameservers,omitempty"`
 }

pkg/types/vsphere/validation/platform_test.go

@@ -898,6 +898,47 @@ func TestValidatePlatform(t *testing.T) {
 			config:        validStaticIPInstallConfig(),
 			expectedError: `^test-path.hosts.nameservers: Too many: 4: must have at most 3 items$`,
 		},
+		{
+			name: "Static IP - valid nameserver IPv6",
+			platform: func() *vsphere.Platform {
+				p := validPlatform()
+				p.Hosts = validHosts()
+				p.Hosts[1].NetworkDevice.Nameservers = []string{"2001:4860:4860::8888"}
+				return p
+			}(),
+			config: validStaticIPInstallConfig(),
+		},
+		{
+			name: "Static IP - invalid nameserver",
+			platform: func() *vsphere.Platform {
+				p := validPlatform()
+				p.Hosts = validHosts()
+				p.Hosts[1].NetworkDevice.Nameservers = []string{"not-an-ip"}
+				return p
+			}(),
+			config:        validStaticIPInstallConfig(),
+			expectedError: `^test-path.hosts.nameservers: Invalid value: "not-an-ip": "not-an-ip" is not a valid IP$`,
+		},
+		{
+			name: "Static IP - empty gateway is valid",
+			platform: func() *vsphere.Platform {
+				p := validPlatform()
+				p.Hosts = validHosts()
+				p.Hosts[1].NetworkDevice.Gateway = ""
+				return p
+			}(),
+			config: validStaticIPInstallConfig(),
+		},
+		{
+			name: "Static IP - valid IPv6 CIDR ipAddrs",
+			platform: func() *vsphere.Platform {
+				p := validPlatform()
+				p.Hosts = validHosts()
+				p.Hosts[1].NetworkDevice.IPAddrs = []string{"2001:db8::1/64"}
+				return p
+			}(),
+			config: validStaticIPInstallConfig(),
+		},
 		{
 			name: "Static IP - No bootstrap host",
 			platform: func() *vsphere.Platform {