Skip to content

NHG Unequal Cost Members - #2330

Merged
tjchadaga merged 1 commit into
opencomputeproject:masterfrom
JaiOCP:WECMP
Aug 18, 2026
Merged

NHG Unequal Cost Members#2330
tjchadaga merged 1 commit into
opencomputeproject:masterfrom
JaiOCP:WECMP

Conversation

@JaiOCP

@JaiOCP JaiOCP commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR brings in support for high performant fabric where NHG is created with prior information about the members with weights.

NOS can use sai_query_attribute_capability() to find out if the platform supports such behavior or not. Legacy implementation will always return the status as not supported attribute.

#2302 is closed as it diverged too much from origin

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@JaiOCP

JaiOCP commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@rck-innovium @kcudnik @sathk-marvell @tjchadaga
New PR is opened. Please approve again

@JaiOCP

JaiOCP commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@sathk-marvell @rck-innovium Please approve. We need to get these PRs in the next release

@kcudnik

kcudnik commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

codeQL shows your code is not cool XD

@JaiOCP

JaiOCP commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

codeQL shows your code is not cool XD

what does this mean Kamil? Is there anything that I need to take care off?

@kcudnik

kcudnik commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

im just messing aroud :D not sure why its failing

@JaiOCP

JaiOCP commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

im just messing aroud :D not sure why its failing

lol you sure got me there :)

@tjchadaga

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
@tjchadaga

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@tjchadaga

Copy link
Copy Markdown
Collaborator

@rck-innovium - could you please help complete the review?

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Aug 17, 2026
@tjchadaga
tjchadaga merged commit 01535dc into opencomputeproject:master Aug 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants