Skip to content

Commit ff6139d

Browse files
nowsprintingclaude
andcommitted
TEMPORARY Remove quotes from testCategory in customParameters
unity-test-runner v4.4.0 delegates execution to the game-ci CLI, which interpolates each env value into a `sh -c` command string without escaping (`--env NAME="${value}"`). The inner double quotes closed that wrapper early, letting `;` split the command and leaving `docker run` without an image. Unquoted, the value reaches the container identically to before, and stays compatible with the pre-CLI action architecture. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 2871c33 commit ff6139d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/test-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
githubToken: ${{ secrets.GITHUB_TOKEN }}
6969
unityVersion: ${{ matrix.unityVersion }} # Default is `auto`
7070
checkName: test result (${{ matrix.unityVersion }}, ${{ matrix.testMode }})
71-
customParameters: -testCategory "Integration;!IgnoreCI" -testHelperScreenshotDirectory /github/workspace/artifacts/Screenshots
71+
customParameters: -testCategory Integration;!IgnoreCI -testHelperScreenshotDirectory /github/workspace/artifacts/Screenshots
7272
# Note: `/github/workspace/artifacts` is the artifacts path inside the game-ci container
7373
testMode: ${{ matrix.testMode }}
7474
env:

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
githubToken: ${{ secrets.GITHUB_TOKEN }}
9090
unityVersion: ${{ matrix.unityVersion }} # Default is `auto`
9191
checkName: test result (${{ matrix.unityVersion }}, ${{ matrix.testMode }})
92-
customParameters: -testCategory "!IgnoreCI;!Integration" -testHelperScreenshotDirectory /github/workspace/artifacts/Screenshots
92+
customParameters: -testCategory !IgnoreCI;!Integration -testHelperScreenshotDirectory /github/workspace/artifacts/Screenshots
9393
# Note: `/github/workspace/artifacts` is the artifacts path inside the game-ci container
9494
coverageOptions: generateAdditionalMetrics;generateTestReferences;generateHtmlReport;generateAdditionalReports;dontClear;assemblyFilters:${{ env.assembly_filters }}
9595
# see: https://docs.unity3d.com/Packages/com.unity.testtools.codecoverage@1.2/manual/CoverageBatchmode.html

0 commit comments

Comments
 (0)