Skip to content

Commit d4623d7

Browse files
committed
fix styling of disconnect github button and remove comma
1 parent 94f918b commit d4623d7

3 files changed

Lines changed: 28 additions & 13 deletions

File tree

theme/common.less

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -952,6 +952,19 @@ Avatar
952952
width: 0;
953953
}
954954

955+
.common-menu-dropdown-pane li.common-menu-dropdown-item.common-button.github-menuitem {
956+
padding: 8px 18px;
957+
958+
.avatar img {
959+
position: relative;
960+
left: -0.25em;
961+
width: 1.5em;
962+
height: 1.5em;
963+
border-radius: 1.5em;
964+
margin-right: 0.45em;
965+
}
966+
}
967+
955968
/* Json editor */
956969
#pxtJsonEditor .ui.content {
957970
padding: 1rem;

webapp/src/container.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,13 +538,13 @@ export class SettingsMenu extends data.Component<SettingsMenuProps, SettingsMenu
538538
items.push({ role: "separator" });
539539
items.push({
540540
role: "menuitem",
541-
className: "ui item",
541+
className: "github-menuitem",
542542
title: lf("Unlink {0} from GitHub", githubUser.name),
543543
onClick: this.signOutGithub,
544544
children: <>
545545
<div className="avatar" role="presentation">
546-
<img className="ui circular image" src={githubUser.photo} alt={lf("User picture")} />
547-
</div>,
546+
<img src={githubUser.photo} alt={lf("User picture")} />
547+
</div>
548548
{lf("Disconnect GitHub")}
549549
</>
550550
});

webapp/src/projects.tsx

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -707,13 +707,13 @@ export class ProjectSettingsMenu extends data.Component<ProjectSettingsMenuProps
707707
items.push({ role: "separator" });
708708
items.push({
709709
role: "menuitem",
710-
className: "ui item",
710+
className: "github-menuitem",
711711
title: lf("Unlink {0} from GitHub", githubUser.name),
712712
onClick: this.signOutGithub,
713713
children: <>
714714
<div className="avatar" role="presentation">
715-
<img className="ui circular image" src={githubUser.photo} alt={lf("User picture")} />
716-
</div>,
715+
<img src={githubUser.photo} alt={lf("User picture")} />
716+
</div>
717717
{lf("Disconnect GitHub")}
718718
</>
719719
});
@@ -758,13 +758,15 @@ export class ProjectSettingsMenu extends data.Component<ProjectSettingsMenuProps
758758
});
759759
}
760760

761-
return <MenuDropdown
762-
id="settings-menuitem"
763-
className="settings-menuitem"
764-
title={lf("Settings")}
765-
icon="icon setting large"
766-
items={items}
767-
/>
761+
return (
762+
<MenuDropdown
763+
id="settings-menuitem"
764+
className="settings-menuitem"
765+
title={lf("Settings")}
766+
icon="icon setting large"
767+
items={items}
768+
/>
769+
);
768770
}
769771
}
770772

0 commit comments

Comments
 (0)