Skip to content

refactor(Algebra/Polynomial): make coeff return a Finsupp#41544

Open
YaelDillies wants to merge 3 commits into
leanprover-community:masterfrom
YaelDillies:polynomial_coeff
Open

refactor(Algebra/Polynomial): make coeff return a Finsupp#41544
YaelDillies wants to merge 3 commits into
leanprover-community:masterfrom
YaelDillies:polynomial_coeff

Conversation

@YaelDillies

@YaelDillies YaelDillies commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This matches AddMonoidAlgebra.

Change made by myself, build fixed by Claude Opus, with the fixes reviewed by myself again.

Assisted-by: Claude Opus 4.8


Open in Gitpod

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR summary aaeb4a2c90

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- unavailable)

⚠️ The Mathlib cache for this PR's merge-base isn't on the server (typically a bors-batch intermediate that CI never built). Merge master into this PR and push to refresh.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit aaeb4a2c90
Reference commit e3b73828b0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant