feat(BA-6890): add kernel scheduling-history repository search scope#12868
Merged
Conversation
This was referenced Jul 15, 2026
Merged
jopemachine
force-pushed
the
feat/BA-6889-kernel-history-conditions-orders
branch
2 times, most recently
from
July 15, 2026 09:40
1d85def to
657f1a6
Compare
jopemachine
force-pushed
the
feat/BA-6890-kernel-history-repository-scope
branch
2 times, most recently
from
July 15, 2026 09:56
f9eff31 to
3cda92e
Compare
jopemachine
commented
Jul 15, 2026
jopemachine
commented
Jul 15, 2026
jopemachine
force-pushed
the
feat/BA-6890-kernel-history-repository-scope
branch
2 times, most recently
from
July 20, 2026 03:19
d384322 to
05a2d77
Compare
Base automatically changed from
feat/BA-6889-kernel-history-conditions-orders
to
main
July 20, 2026 04:15
jopemachine
force-pushed
the
feat/BA-6890-kernel-history-repository-scope
branch
from
July 20, 2026 04:22
05a2d77 to
d7b27fc
Compare
jopemachine
marked this pull request as ready for review
July 20, 2026 04:30
Contributor
There was a problem hiding this comment.
Pull request overview
Adds scoped kernel scheduling-history repository searches by session ID, kernel ID, or both.
Changes:
- Adds scope validation, query conditions, and existence checks.
- Adds repository and database search paths.
- Adds scope-focused tests and a changelog entry.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
changes/12868.feature.md |
Documents the repository scope feature. |
src/ai/backend/manager/errors/kernel.py |
Adds the empty-scope error. |
src/ai/backend/manager/repositories/scheduling_history/__init__.py |
Exports the new scope. |
src/ai/backend/manager/repositories/scheduling_history/types.py |
Defines scope filtering and validation. |
src/ai/backend/manager/repositories/scheduling_history/repository.py |
Exposes scoped kernel-history search. |
src/ai/backend/manager/repositories/scheduling_history/db_source/db_source.py |
Executes the scoped database query. |
tests/unit/manager/repositories/scheduling_history/test_kernel_scheduling_history_scope.py |
Tests scope construction and conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jopemachine
force-pushed
the
feat/BA-6890-kernel-history-repository-scope
branch
2 times, most recently
from
July 20, 2026 04:42
7b9fa27 to
8332a48
Compare
Add KernelSchedulingHistorySearchScope and the scoped repository read path. Unlike the session/deployment/route scopes, which each carry one required entity id, a kernel query is scoped by session_id (all of a session's kernels), kernel_id, or both. to_condition() filters on each axis given and intersects when both are; existence_checks covers the corresponding session and kernel rows. At least one axis is required: an empty scope would silently degenerate into an unscoped, system-wide search, so it raises EmptyKernelSchedulingHistoryScope. The shared DTO validates this too (BA-6891); the scope defends it again because it is what the repository actually trusts. search_kernel_scoped_history mirrors the existing unscoped method, differing only in passing the scope to execute_batch_querier. The service actions that build this scope land in BA-6891. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jopemachine
force-pushed
the
feat/BA-6890-kernel-history-repository-scope
branch
from
July 20, 2026 04:47
8332a48 to
c04a047
Compare
HyeockJinKim
approved these changes
Jul 20, 2026
HyeockJinKim
enabled auto-merge (squash)
July 20, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked PRs
BA-6887fix: kernel history conditions reference the real status columnsBA-6889models: kernel query conditions and ordersBA-6890repository: kernel search scope and scoped search ← you are hereBA-6891DTO + service: kernel v2 DTOs and search actionsBA-6892adapter + REST v2: kernel endpointsBA-6893SDK + CLI: kernel commandsMerge in order, bottom-up. Each PR is based on the one above it, so its diff shows only its own layer.
What
KernelSchedulingHistorySearchScopeplus the scoped repository read path (search_kernel_scoped_historyon the repository and db_source).Why this scope is shaped differently
The session / deployment / route scopes each carry one required entity id. A kernel query is scoped by:
session_id— all of that session's kernels, orkernel_id— one kernel, orto_condition()filters on each axis given andANDs them;existence_checkscovers the correspondingSessionRow/KernelRow.At least one axis is required. An empty scope would silently degenerate into an unscoped, system-wide search — exactly what a scoped search exists to prevent — so it raises
EmptyKernelSchedulingHistoryScope. The shared DTO validates this too (#12869); the scope defends it again because the scope is what the repository actually trusts, and it is reachable from GraphQL (BA-6883) as well as REST.Review notes
search_kernel_scoped_historydiffers from the existing unscoped method by exactly one argument:scopes=[scope]onexecute_batch_querier.tests/AGENTS.mdnames "empty scope → error" as a canonical case to cover.The service actions that build this scope are #12869.
🤖 Generated with Claude Code