Skip to content

Project name should be taken from package.json or now.json in priority #138

Description

@floo51

Describe the bug
When deploying, the project name is taken from the directory name.

Now takes the project name from:

  1. now.json
  2. package.json
  3. directory name

To Reproduce

  1. Create a new meteor app in a folder named "bonjour".
  2. Add to package.json:
  "now":{
    "name": "hello",
  }
  1. Deploy
  2. App will deployed to bonjour-xyz.now.sh

Expected behavior

App should be deployed to hello-xyz.now.sh

Additional context

It's especially annoying when willing to do now alias since that takes the name in the package.json, which is not the app name meteor-now used.

Probably around here:

export const projectName = (() => getFolderName(process.cwd()))();

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions