Hi and thanks for the driver!
I've been running it on an X96 Max (S905X2, SPI/fd628) under ophub's Armbian (kernel 6.18.33-ophub), packaged as DKMS, and it works well; the setup survives reboots and kernel updates.
The ophub maintainer has asked to build the driver into their kernel fork (linux-6.18.y) so users don't need DKMS (context: PR ophub/amlogic-s9xxx-armbian#3566 and issue ophub/amlogic-s9xxx-armbian#3567). I'm glad to prepare that downstream PR from your posted v6 patches, with your Signed-off-by preserved and a link back to your upstream series, but I didn't want to push your pre-merge work into a third-party kernel over your head.
Would you rather send that PR yourself, or are you fine with me doing it? Either way I'll add a Tested-by: for the S905X2 variant on your v6 series to help it land.
For reference, the DKMS recipe I'm using is here: https://github.com/B00StER/x96max-armbian-frontpanel
Hi and thanks for the driver!
I've been running it on an X96 Max (S905X2, SPI/fd628) under ophub's Armbian (kernel 6.18.33-ophub), packaged as DKMS, and it works well; the setup survives reboots and kernel updates.
The ophub maintainer has asked to build the driver into their kernel fork (
linux-6.18.y) so users don't need DKMS (context: PR ophub/amlogic-s9xxx-armbian#3566 and issue ophub/amlogic-s9xxx-armbian#3567). I'm glad to prepare that downstream PR from your posted v6 patches, with yourSigned-off-bypreserved and a link back to your upstream series, but I didn't want to push your pre-merge work into a third-party kernel over your head.Would you rather send that PR yourself, or are you fine with me doing it? Either way I'll add a
Tested-by:for the S905X2 variant on your v6 series to help it land.For reference, the DKMS recipe I'm using is here: https://github.com/B00StER/x96max-armbian-frontpanel