Skip to content

send_bulk_message needs more refined error handling #18

Description

@MrCsabaToth

Right now send_bulk_message can emit BadDeviceToken and a PartialBulkMessage exceptions. When filling the good_registration_ids and bad_registration_ids the exception is pac-man style (catch all) and doesn't really distinguish between various types of errors. Only those 403 TokenError and 410 TokenInactive should be considered as id problems. Otherwise the user's APNs server will inactivate such device tokens which are still valid!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions