From 51b0cfa9bfb0157871c6b363e995742fc41efe59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20Bl=C3=A5man?= Date: Tue, 4 Aug 2026 21:16:33 +0000 Subject: [PATCH 1/2] Don't allow signing up to intoduction event without group --- services/event_signup_service.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/services/event_signup_service.py b/services/event_signup_service.py index 570231fc..69e51c57 100644 --- a/services/event_signup_service.py +++ b/services/event_signup_service.py @@ -34,11 +34,7 @@ def signup_to_event(event: Event_DB, user: User_DB, data: EventSignupCreate, man ): raise HTTPException(400, detail="User already signed up to chosen event") - if ( - manage_permission == False - and data.group_name is not None - and not is_group_allowed(event, user, data.group_name) - ): + if manage_permission == False and not is_group_allowed(event, user, data.group_name): raise HTTPException(status.HTTP_403_FORBIDDEN, detail="User cannot sign up with this group") signup = EventUser_DB(user=user, user_id=user.id, event=event, event_id=event.id) @@ -87,10 +83,8 @@ def update_event_signup(event: Event_DB, data: EventSignupUpdate, user_id: int, if signup is None: raise HTTPException(status.HTTP_404_NOT_FOUND) - if ( - manage_permission == False - and data.group_name is not None - and not is_group_allowed(event, db.query(User_DB).filter(User_DB.id == user_id).one(), data.group_name) + if manage_permission == False and not is_group_allowed( + event, db.query(User_DB).filter(User_DB.id == user_id).one(), data.group_name ): raise HTTPException(status.HTTP_403_FORBIDDEN, detail="User cannot sign up with this group") From cdd551d04422c02515c404273ac3f93e4a0907be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20Bl=C3=A5man?= Date: Wed, 5 Aug 2026 11:07:21 +0000 Subject: [PATCH 2/2] Early false return for group_name None --- services/event_signup_service.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/services/event_signup_service.py b/services/event_signup_service.py index 69e51c57..f0d2363c 100644 --- a/services/event_signup_service.py +++ b/services/event_signup_service.py @@ -131,6 +131,9 @@ def get_allowed_groups(event: Event_DB, user: User_DB): def is_group_allowed(event: Event_DB, user: User_DB, group_name: str | None): if event.is_nollning_event: + if group_name is None: + return False + allowed_group_types = event.mentor_group_types or list(get_args(GROUP_TYPE)) is_event_allowed = False for gu in user.group_users: