From 68a6ddb3d27c1daf16423e6badd802e7f47758cd Mon Sep 17 00:00:00 2001 From: Yuchen Shi Date: Tue, 7 Jul 2026 13:35:53 -0700 Subject: [PATCH 1/3] [spr] initial version Created using spr 1.3.6-beta.1 --- CHANGELOG.md | 1 + src/commands/dataconnect-execute.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7dc0667ecf6..40139ec728d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ - Fixed an issue in `apps:create` where App Store ID was always prompted for even when unnecessary. - Add `functions:lifecycle:list` and `functions:lifecycle:run` commands to view and run lifecycle hooks in isolation. +- Fixed `dataconnect:execute` command help text. The right env var should be FIREBASE_DATA_CONNECT_EMULATOR_HOST, with an underscore between DATA and CONNECT. diff --git a/src/commands/dataconnect-execute.ts b/src/commands/dataconnect-execute.ts index e2c8d054d41..09fd181d080 100644 --- a/src/commands/dataconnect-execute.ts +++ b/src/commands/dataconnect-execute.ts @@ -24,7 +24,7 @@ let stdinUsedFor: string | undefined = undefined; export const command = new Command("dataconnect:execute [file] [operationName]") .description( - "execute a SQL Connect query or mutation. If FIREBASE_DATACONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec', executes against the emulator instead.", + "execute a SQL Connect query or mutation. If FIREBASE_DATA_CONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec', executes against the emulator instead.", ) .option( "--service ", From 2420b46473668328f1af76426c87921ad4e268c0 Mon Sep 17 00:00:00 2001 From: Yuchen Shi Date: Tue, 7 Jul 2026 13:39:38 -0700 Subject: [PATCH 2/3] Update src/commands/dataconnect-execute.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- src/commands/dataconnect-execute.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/dataconnect-execute.ts b/src/commands/dataconnect-execute.ts index 09fd181d080..717eb2c39f9 100644 --- a/src/commands/dataconnect-execute.ts +++ b/src/commands/dataconnect-execute.ts @@ -24,7 +24,7 @@ let stdinUsedFor: string | undefined = undefined; export const command = new Command("dataconnect:execute [file] [operationName]") .description( - "execute a SQL Connect query or mutation. If FIREBASE_DATA_CONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec', executes against the emulator instead.", + "execute a SQL Connect query or mutation. If FIREBASE_DATA_CONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec'), executes against the emulator instead.", ) .option( "--service ", From 3ddc41c3ef74236aebeb5d38cd653bd7dcb91b9f Mon Sep 17 00:00:00 2001 From: Yuchen Shi Date: Mon, 13 Jul 2026 13:59:38 -0700 Subject: [PATCH 3/3] Use constant for the env var name --- src/commands/dataconnect-execute.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/dataconnect-execute.ts b/src/commands/dataconnect-execute.ts index 717eb2c39f9..49eefcbf29f 100644 --- a/src/commands/dataconnect-execute.ts +++ b/src/commands/dataconnect-execute.ts @@ -24,7 +24,7 @@ let stdinUsedFor: string | undefined = undefined; export const command = new Command("dataconnect:execute [file] [operationName]") .description( - "execute a SQL Connect query or mutation. If FIREBASE_DATA_CONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec'), executes against the emulator instead.", + `execute a SQL Connect query or mutation. If ${Constants.FIREBASE_DATACONNECT_EMULATOR_HOST} is set (such as during 'firebase emulator:exec'), executes against the emulator instead.`, ) .option( "--service ",