From 253898e6ca2edfa95bdd2103a1987231d0a4bb08 Mon Sep 17 00:00:00 2001 From: RemDelaporteMathurin Date: Wed, 15 Jul 2026 09:20:32 -0400 Subject: [PATCH 1/2] note --- src/festim/advection.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/festim/advection.py b/src/festim/advection.py index 10081f823..ad569fba5 100644 --- a/src/festim/advection.py +++ b/src/festim/advection.py @@ -149,6 +149,8 @@ def convert_input_value( ) # create vector function space and function + + # NOTE: this is what needs to change!! @jhdark @kaelyn v_cg = basix.ufl.element( "Lagrange", function_space.mesh.topology.cell_name(), From 26267cc7383bcda19ecc14fbbfce8d66b98a5e04 Mon Sep 17 00:00:00 2001 From: RemDelaporteMathurin Date: Wed, 15 Jul 2026 09:20:50 -0400 Subject: [PATCH 2/2] better note --- src/festim/advection.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/festim/advection.py b/src/festim/advection.py index ad569fba5..4955a6e99 100644 --- a/src/festim/advection.py +++ b/src/festim/advection.py @@ -150,11 +150,10 @@ def convert_input_value( # create vector function space and function - # NOTE: this is what needs to change!! @jhdark @kaelyn v_cg = basix.ufl.element( "Lagrange", function_space.mesh.topology.cell_name(), - 1, + 1, # NOTE: this is what needs to change!! @jhdark @kaelyn shape=(function_space.mesh.topology.dim,), ) self.vector_function_space = fem.functionspace(function_space.mesh, v_cg)