From 53284b36b90bba48d49a1c03cb38e895a65d5b24 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Sat, 20 Jun 2026 21:35:48 +0000
Subject: [PATCH] Fix pyright type hinting issue with the project_dribs
 iterable in test_editing.py

Co-authored-by: loleg <31819+loleg@users.noreply.github.com>
---
 poetry.lock           | 37 +++++++++++++++++++++++++++++++++++--
 pyproject.toml        |  1 +
 tests/test_editing.py |  5 ++---
 3 files changed, 38 insertions(+), 5 deletions(-)

diff --git a/poetry.lock b/poetry.lock
index 77096da9..c4d65fdd 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -1,4 +1,4 @@
-# This file is automatically @generated by Poetry 2.3.4 and should not be changed by hand.
+# This file is automatically @generated by Poetry 2.3.2 and should not be changed by hand.
 
 [[package]]
 name = "alembic"
@@ -2299,6 +2299,18 @@ files = [
     {file = "micawber-0.5.6.tar.gz", hash = "sha256:20dc4e074c17a741880b489cf2558845c050987f5b796c8ff07ea2ff011a8c8d"},
 ]
 
+[[package]]
+name = "nodeenv"
+version = "1.10.0"
+description = "Node.js virtual environment builder"
+optional = false
+python-versions = "!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*,!=3.5.*,!=3.6.*,>=2.7"
+groups = ["dev"]
+files = [
+    {file = "nodeenv-1.10.0-py2.py3-none-any.whl", hash = "sha256:5bb13e3eed2923615535339b3c620e76779af4cb4c6a90deccc9e36b274d3827"},
+    {file = "nodeenv-1.10.0.tar.gz", hash = "sha256:996c191ad80897d076bdfba80a41994c2b47c68e224c542b48feba42ba00f8bb"},
+]
+
 [[package]]
 name = "numpy"
 version = "2.2.6"
@@ -2836,6 +2848,27 @@ lxml = ">=2.1"
 [package.extras]
 test = ["pytest", "pytest-cov", "requests", "webob", "webtest"]
 
+[[package]]
+name = "pyright"
+version = "1.1.410"
+description = "Command line wrapper for pyright"
+optional = false
+python-versions = ">=3.7"
+groups = ["dev"]
+files = [
+    {file = "pyright-1.1.410-py3-none-any.whl", hash = "sha256:5e961bed37cacf96b3f7cd7b1da39b350a9239aa2e69138d0e88f728cfaf296c"},
+    {file = "pyright-1.1.410.tar.gz", hash = "sha256:07a073b8ba6749826773c1269773efa11b93440d9a6aa60419d9a3172d6dc488"},
+]
+
+[package.dependencies]
+nodeenv = ">=1.6.0"
+typing-extensions = ">=4.1"
+
+[package.extras]
+all = ["nodejs-wheel-binaries", "twine (>=3.4.1)"]
+dev = ["twine (>=3.4.1)"]
+nodejs = ["nodejs-wheel-binaries"]
+
 [[package]]
 name = "pystache"
 version = "0.6.8"
@@ -3950,4 +3983,4 @@ testing = ["coverage[toml]", "zope.event", "zope.testing"]
 [metadata]
 lock-version = "2.1"
 python-versions = ">=3.10,<4"
-content-hash = "6ce6e9842d753021fea22eb56323b703d9c673bd4e953cddf724b02c2f895029"
+content-hash = "d55bfe82dbbc8d3f1ca8c313379ca7a1dbee09ea5deee05b9956b3536dbe219f"
diff --git a/pyproject.toml b/pyproject.toml
index ada1b3b5..efa99590 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -76,6 +76,7 @@ pyopenssl = "*"
 pytest = "*"
 WebTest = "*"
 coverage = "*"
+pyright = "^1.1.410"
 
 [tool.poetry.requires-plugins]
 poetry-plugin-export = ">=1.8"
diff --git a/tests/test_editing.py b/tests/test_editing.py
index f9fc4f13..c778b576 100644
--- a/tests/test_editing.py
+++ b/tests/test_editing.py
@@ -160,12 +160,11 @@ def test_project_activities(self, db, testapp):
         ProjectActivity(project, 'star', user)
         ProjectActivity(project, 'update', user)
         ProjectActivity(project, 'boost', user, 'Data whiz', 'lorem ipsum')
-        project_dribs = project.all_dribs()
+        project_dribs: list[dict] = project.all_dribs()
 
         # event start, project joined, updated, boosted
         assert len(project_dribs) == 4
-        # TODO: check why we have an issue here with the iterable
-        project_badge = [s for s in project_dribs if s['name'] == 'boost']  # pyright: ignore
+        project_badge = [s for s in project_dribs if s['name'] == 'boost']
         assert len(project_badge) == 1
 
         # Check that user is part of event