Skip to content

Commit fd0bfdf

Browse files
docs: stop duplicating the lib.pvl digest in REPRODUCING.md
The doc quoted an expected SHA-256 of 51b54eed55ee23d19386f7a62fb68dbf3a25ef80d5567c77f86e1c8d20f6395b, but the real digest of the committed extraction/lib.pvl -- and the value in extraction/lib.pvl.sha256 -- is 4914798cd53878dec1b3f43a00dad9d322013cd0cc09f14e7634e6366c70572c. The prose copy had gone stale. Nothing was actually wrong with the extraction: the L2 recipe checks the .sha256 file, not the doc, so it kept passing. But anyone eyeballing REPRODUCING.md would conclude the extraction had drifted when it had not -- which is a bad failure mode for a document whose whole job is to certify byte-identity. Point at extraction/lib.pvl.sha256 instead of restating the value. That file is regenerated alongside lib.pvl, so it cannot drift, and it is what `shasum -c` already verifies. Repeating the digest next to the file that holds it is what caused this, so the fix removes the duplication rather than refreshing it.
1 parent 0694785 commit fd0bfdf

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

proofs/proverif/REPRODUCING.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,16 @@ python3 hax.py extract-proverif # regenerate extraction/lib.pvl
117117
shasum -a 256 -c proofs/proverif/extraction/lib.pvl.sha256 # must match
118118
```
119119

120-
Expected `lib.pvl` digest (SHA-256):
121-
`51b54eed55ee23d19386f7a62fb68dbf3a25ef80d5567c77f86e1c8d20f6395b`
122-
(also stored in `extraction/lib.pvl.sha256`).
120+
The expected `lib.pvl` digest (SHA-256) lives in `extraction/lib.pvl.sha256`,
121+
which is what the `shasum -c` above checks. Read it with:
122+
123+
```bash
124+
cat proofs/proverif/extraction/lib.pvl.sha256
125+
```
126+
127+
That file is the single source of truth: it is regenerated alongside `lib.pvl`,
128+
so it cannot drift. Do not copy the digest into prose here — an earlier copy
129+
went stale and made the extraction look like it had drifted when it had not.
123130

124131
### Regression (the SPQR refactors are behaviour-preserving)
125132

0 commit comments

Comments
 (0)