Pasting images from the clipboard no longer works in v. 13

[dca00]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to any chat
2. Paste an image from the clipboard
3. Nothing happens

Expected behavior
The image should paste into the chat

Screenshots

Environment (please complete the following information):

• Desktop or Mobile? Desktop
• Browser [e.g. Chrome, Firefox] any
• Converse.js version [e.g. 13.0.1]

Additional context
Add any other context about the problem here.

Reverting to v. 12 restores the normal function of the clipboard

[kicken]

Works fine for me in my tests using v13.0.1 in Firefox and the Desktop app.

Try opening your browser's developer console and seeing if any errors show when pasting. If so, provide them here.

[dca00]

Nothing new in the console when pasting, unlike in the previous versions.

[jcbrand]

Works fine for me as well using Brave (Chromium-based).

[dca00]

I totally understand that since you package the minified .js file, it is hard to do a line-by-line comparison of the current and previous release, but you should have the full version somewhere that you later minify, so you still should be able to compare and see what could possibly affect the clipboard processing. One of the things that you've changed is the pasting of rich text, so you did touch that function, and the new code will be the 1st suspect. HTH.

[kicken]

do a line-by-line comparison of the current and previous release

You can do that right here on GitHub if you want to: Compare v12.0.0 to v13.0.1. Without being able to re-produce the issue though, comparing the code is a bit of a waste of time. Since we've been unable to reproduce the issue, you'll have to either do the debugging on your end, or at the very least try and provide some better reproduction steps and information about your environment like what server you're using, how you're connecting, where you're copying an image from, what kind of chat you paste into, etc. The more detail you can provide the better.

The only change I can see that might be related to this is: Allow plain text paste by holding shift. If you try and paste an image with Ctrl+Shift+V, it won't do anything because that is intended to paste text and not images. Ctrl+v still pastes images.

[dca00]

I could, but it won't do me any good because I am not a programmer, and I do not know JavaScript.
All I know is that side by side, in the 2 tabs of the same browser, it works in v. 12 but does not work in v. 13, with the same config HTML.
We paste images with Shift-Ins. I tried Shift-V, and it worked. Did you block Shift-Ins?

[kicken]

The change mentioned causes converse.js to paste as plain text when holding down the Shift key. This has the side effect of making Shift+Ins only capable of pasting text. If you want to paste images, use the more common Ctrl+V key combination.

[dca00]

It's worth looking into the more generic approach: the handling of the clipboard paste event instead of the keypress event.
No one is going to re-train their keyboard habits to accommodate this piece of software. Ctrl-Ins and Shift-Ins are CUA that pre-dates the Windowze Ctrl-C/Ctrl-V. Needless to say that Ctrl-C is abort on all decent OSs.