From a08fcddc8eab4dbdf6e41c3def1625786710b529 Mon Sep 17 00:00:00 2001 From: Disconnect3d Date: Tue, 9 Jun 2020 18:06:30 +0200 Subject: [PATCH] Fix netns directory permissions Changed created netns directory permissions from 644 (-w----r--) to 0644 (rw-r--r--) when calling `MkdirAll(...)`. PoC: ``` dc@jhtc:~/gogo$ cat makedir.go package main import "os" func main() { os.MkdirAll("644", 644) os.MkdirAll("0644", 0644) } dc@jhtc:~/gogo$ go run main.go dc@jhtc:~/gogo$ ls -la *644 -rw-r--r-- 1 dc dc 7 Jun 9 17:05 0644 --w----r-- 1 dc dc 7 Jun 9 17:05 644 ``` --- mgmtfn/mesosplugin/cnidriver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mgmtfn/mesosplugin/cnidriver.go b/mgmtfn/mesosplugin/cnidriver.go index 6e8f5b8b1..e721afcf2 100644 --- a/mgmtfn/mesosplugin/cnidriver.go +++ b/mgmtfn/mesosplugin/cnidriver.go @@ -153,7 +153,7 @@ func (cniReq *cniServer) configureNetNs(ovsEpDriver *drivers.OperEndpointState, mResp *master.CreateEndpointResponse, nwState *mastercfg.CfgNetworkState) error { - os.MkdirAll(netNsDir, 644) + os.MkdirAll(netNsDir, 0644) // link new name space if _, err := os.Stat(netNsDir + cniReq.pluginArgs.CniContainerid); err != nil {