Skip to content

Add domonic conda-forge recipe - #34677

Open
byteface wants to merge 8 commits into
conda-forge:mainfrom
byteface:add-domonic-recipe
Open

Add domonic conda-forge recipe#34677
byteface wants to merge 8 commits into
conda-forge:mainfrom
byteface:add-domonic-recipe

Conversation

@byteface

Copy link
Copy Markdown

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated recipe".
  • Recipe uses the v1 recipe.yaml format, or this PR explains the exceptional requirement for deprecated v0.
  • License file is packaged (see the v1 example recipe for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@byteface

Copy link
Copy Markdown
Author

@conda-forge/help-python please help, ready for review!

@conda-forge-admin

conda-forge-admin commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/domonic/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/domonic/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.

    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
  • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ The recipe sets python_min to 3.10, which is equal or lower than the default provided by conda-forge's global pinning. Please remove the redefinition.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/33305217677. Examine the logs at this URL for more detail.

@eunos-1128

Copy link
Copy Markdown
Contributor

Nowadays, you need to use the v1 recipe format before proceeding to be reviewed.

Thank you!

docs.conda.io/projects/conda-build/en/latest/user-guide/v1-recipes.html#migrating-recipes

conda-recipe-manager convert recipe/meta.yaml > recipe/recipe.yaml

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/domonic/recipe.yaml) and found it was in an excellent condition.

@byteface

byteface commented Sep 6, 2026

Copy link
Copy Markdown
Author

@conda-forge/help-python please help, ready for review!

python_version:
- ${{ python_min }}.*
- "*"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- script:
- domonic --help

version: ${{ version }}

source:
url: https://files.pythonhosted.org/packages/source/d/domonic/domonic-${{ version }}.tar.gz

@eunos-1128 eunos-1128 Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the link like this format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants