From 69c715ad058ad38da003fb8bf56a62a57f7c0b53 Mon Sep 17 00:00:00 2001 From: Kidus Getachew Date: Tue, 30 Jun 2026 23:00:30 -0400 Subject: [PATCH 1/3] test(convert): cover never_convert_lossy_files in playlist entry tests Add a parametrize case to test_playlist_entry verifying that when never_convert_lossy_files=True prevents transcoding of a lossy file, the generated playlist entry keeps the original file extension. Co-Authored-By: Claude Sonnet 4.6 --- test/plugins/test_convert.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/plugins/test_convert.py b/test/plugins/test_convert.py index 43b7e315a7..402f5c58bd 100644 --- a/test/plugins/test_convert.py +++ b/test/plugins/test_convert.py @@ -252,17 +252,20 @@ def test_force_overrides(self, config_overrides): assert self.file_endswith(converted, "opus") @pytest.mark.parametrize( - "args,no_convert,expected_entry", + "args,no_convert,never_convert_lossy,expected_entry", [ - _p((), None, "converted.mp3", id="config-format"), - _p(("--format", "opus"), None, "converted.ops", id="cli-format"), - _p((), "format:ogg", "converted.ogg", id="not-transcoded"), - _p(("--keep-new",), None, "converted.ogg", id="keep-new"), + _p((), None, False, "converted.mp3", id="config-format"), + _p(("--format", "opus"), None, False, "converted.ops", id="cli-format"), + _p((), "format:ogg", False, "converted.ogg", id="not-transcoded"), + _p(("--keep-new",), None, False, "converted.ogg", id="keep-new"), + _p((), None, True, "converted.ogg", id="never-convert-lossy"), ], ) - def test_playlist_entry(self, args, no_convert, expected_entry): + def test_playlist_entry(self, args, no_convert, never_convert_lossy, expected_entry): if no_convert: self.config["convert"]["no_convert"] = no_convert + if never_convert_lossy: + self.config["convert"]["never_convert_lossy_files"] = True self.io.addinput("y") self.run_convert(*args, "--playlist", "playlist.m3u8") From 51556ce83e12fd62a7871606f0f9cfd2d7f3e43e Mon Sep 17 00:00:00 2001 From: Kidus Getachew Date: Wed, 1 Jul 2026 00:24:22 -0400 Subject: [PATCH 2/3] fix lint: wrap long test_playlist_entry signature --- test/plugins/test_convert.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/plugins/test_convert.py b/test/plugins/test_convert.py index 402f5c58bd..9c9177e7a4 100644 --- a/test/plugins/test_convert.py +++ b/test/plugins/test_convert.py @@ -261,7 +261,9 @@ def test_force_overrides(self, config_overrides): _p((), None, True, "converted.ogg", id="never-convert-lossy"), ], ) - def test_playlist_entry(self, args, no_convert, never_convert_lossy, expected_entry): + def test_playlist_entry( + self, args, no_convert, never_convert_lossy, expected_entry + ): if no_convert: self.config["convert"]["no_convert"] = no_convert if never_convert_lossy: From 9ac728ee05032b14b729003ada9f2d14ffcafd6b Mon Sep 17 00:00:00 2001 From: Kidus Getachew Date: Wed, 1 Jul 2026 00:27:08 -0400 Subject: [PATCH 3/3] fix format: expand long parametrize line --- test/plugins/test_convert.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/plugins/test_convert.py b/test/plugins/test_convert.py index 9c9177e7a4..6dd8252a22 100644 --- a/test/plugins/test_convert.py +++ b/test/plugins/test_convert.py @@ -255,7 +255,13 @@ def test_force_overrides(self, config_overrides): "args,no_convert,never_convert_lossy,expected_entry", [ _p((), None, False, "converted.mp3", id="config-format"), - _p(("--format", "opus"), None, False, "converted.ops", id="cli-format"), + _p( + ("--format", "opus"), + None, + False, + "converted.ops", + id="cli-format", + ), _p((), "format:ogg", False, "converted.ogg", id="not-transcoded"), _p(("--keep-new",), None, False, "converted.ogg", id="keep-new"), _p((), None, True, "converted.ogg", id="never-convert-lossy"),