Skip to content

Fix update with plugin media flex fields#6783

Open
gaoflow wants to merge 1 commit into
beetbox:masterfrom
gaoflow:fix-5580-update-flex-media-fields
Open

Fix update with plugin media flex fields#6783
gaoflow wants to merge 1 commit into
beetbox:masterfrom
gaoflow:fix-5580-update-flex-media-fields

Conversation

@gaoflow

@gaoflow gaoflow commented Jun 27, 2026

Copy link
Copy Markdown

Summary

  • avoid treating flexible attributes passed to Model.store(fields=...) as fixed table columns
  • add a dbcore regression test for storing a flexattr included in fields
  • add an update command regression test for plugin-added media fields
  • add a changelog note for Update mediafields regression #5580

Fixes #5580.

Tests

  • poe test test/test_dbcore.py test/ui/commands/test_update.py
  • poe lint
  • poe check-format

@gaoflow
gaoflow requested a review from a team as a code owner June 27, 2026 08:52
Copilot AI review requested due to automatic review settings June 27, 2026 08:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.62%. Comparing base (e2889d1) to head (754650f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6783   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files         163      163           
  Lines       21318    21318           
  Branches     3361     3361           
=======================================
  Hits        16122    16122           
  Misses       4405     4405           
  Partials      791      791           
Files with missing lines Coverage Δ
beets/dbcore/db.py 94.41% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@semohr

semohr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Tests

  • uv run --with pytest --with mediafile --with confuse --with jellyfish --with munkres --with musicbrainzngs --with unidecode --with typing_extensions --with-editable . pytest test/test_dbcore.py test/ui/commands/test_update.py -q
  • uv run --with ruff ruff check --config=pyproject.toml beets/dbcore/db.py test/test_dbcore.py test/ui/commands/test_update.py
  • uv run --with ruff ruff format --check --config=pyproject.toml beets/dbcore/db.py test/test_dbcore.py test/ui/commands/test_update.py
  • git diff --check

Please read our contribution guide! We are not using uv in our dev setup currently.

@gaoflow

gaoflow commented Jul 26, 2026

Copy link
Copy Markdown
Author

Sorry — that was my own scratch invocation, not your dev setup. Swapped the description over to the poe tasks. I'll rebase this too, it's picked up a conflict.

@gaoflow
gaoflow force-pushed the fix-5580-update-flex-media-fields branch from 4417fea to 754650f Compare July 26, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update mediafields regression

3 participants