Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix(hooks): always remove finalizers#754

Draft
agaudreault wants to merge 29 commits into
argoproj:masterfrom
agaudreault:fix-hook-finalizer
Draft

fix(hooks): always remove finalizers#754
agaudreault wants to merge 29 commits into
argoproj:masterfrom
agaudreault:fix-hook-finalizer

remove finalizer from completed hooks on terminate

ef00d91
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 13, 2026 in 1s

48.32% (-5.95%) compared to 8849c3f

View this Pull Request on Codecov

48.32% (-5.95%) compared to 8849c3f

Details

Codecov Report

❌ Patch coverage is 73.20574% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.32%. Comparing base (8849c3f) to head (ef00d91).
⚠️ Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 79.27% 30 Missing and 10 partials ⚠️
...kg/utils/kube/kubetest/mock_resource_operations.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   54.26%   48.32%   -5.95%     
==========================================
  Files          64       64              
  Lines        6164     6639     +475     
==========================================
- Hits         3345     3208     -137     
- Misses       2549     3170     +621     
+ Partials      270      261       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.