Add microwindows - #3678
Merged
Merged
Conversation
Without this Make variable, Objects.rules does not add font_fnt.o to the build, causing undefined reference to fnt_createfont at link time. Signed-off-by: Acfboy <AcfboyU@outlook.com>
Acfboy
marked this pull request as ready for review
July 29, 2026 16:07
xiaoxiang781216
approved these changes
Jul 29, 2026
michallenc
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I accidentally removed
HAVE_FNT_SUPPORT = YfromMake.defswhile refactoring config items intoMakefile. Althoughmwconfig.nuttxprovides#define HAVE_FNT_SUPPORT 1at the C preprocessor level, the Make variable is still needed byObjects.rulesto includefont_fnt.oin the build. Without it, linking fails with:This restores the variable in
Makefile, which is the correct location since it is only needed when building the Microwindows library itself, not by external applications.Impact
sim:mwandqemu-intel64:mwusing Microwindows.Testing
sim:mwwithmake -j$(nproc)before and after the fix.Before: link fails. After: link succeeds.