Drop dialect flag for LIMIT after the locking clause

The row-locking clause (FOR UPDATE/FOR SHARE/...) just above is parsed
for every dialect, so gating only the trailing LIMIT/OFFSET behind a
dialect flag was inconsistent. Parse it unconditionally instead and
remove supports_limit_after_locking_clause.

Author: truffle-dev

src/dialect/mod.rs

@@ -1712,20 +1712,6 @@ pub trait Dialect: Debug + Any {
         false
     }
 
-    /// Returns true if this dialect supports a `LIMIT`/`OFFSET` clause placed
-    /// after the row-locking clause (`FOR UPDATE`/`FOR SHARE`/...), in addition
-    /// to the usual position before it.
-    ///
-    /// Example:
-    /// ```sql
-    /// SELECT * FROM t ORDER BY id FOR UPDATE SKIP LOCKED LIMIT 5;
-    /// ```
-    ///
-    /// [PostgreSQL](https://www.postgresql.org/docs/current/sql-select.html)
-    fn supports_limit_after_locking_clause(&self) -> bool {
-        false
-    }
-
     /// Returns true if this dialect supports the `INTERPOLATE` clause
     /// in `ORDER BY` expressions.
     ///

src/dialect/postgresql.rs

@@ -291,10 +291,6 @@ impl Dialect for PostgreSqlDialect {
         true
     }
 
-    fn supports_limit_after_locking_clause(&self) -> bool {
-        true
-    }
-
     fn supports_set_names(&self) -> bool {
         true
     }

src/parser/mod.rs

@@ -14480,9 +14480,12 @@ impl<'a> Parser<'a> {
                 }
             }
 
-            // PostgreSQL accepts `LIMIT`/`OFFSET` after the row-locking clause
-            // (e.g. `... FOR UPDATE SKIP LOCKED LIMIT 5`) as well as before it.
-            if limit_clause.is_none() && self.dialect.supports_limit_after_locking_clause() {
+            // Some databases (e.g. PostgreSQL) accept `LIMIT`/`OFFSET` after the
+            // row-locking clause (`... FOR UPDATE SKIP LOCKED LIMIT 5`) as well
+            // as before it. The locking clause above is parsed for every
+            // dialect, so accept a trailing limit here too rather than gating it
+            // behind a dialect flag.
+            if limit_clause.is_none() {
                 limit_clause = self.parse_optional_limit_clause()?;
             }