Syntax for nodeofferings and nodetemplates in createkubernetescluster

[chunkyen]

Anyone knows how to pass different nodeofferings and nodetemplates for control plane and workernode when calling the createkubernetescluster API? I was testing using cmk and couldn't find any example of the correct syntax.
Thanks

[Pearl1594]

@chunkyen you could do as follows:

create kubernetescluster ... nodeofferings[0].node="control" nodeofferings[0].offering="uuid" nodeofferings[1].node="worker" nodeofferings[1].offering="uuid2" nodetemplates[0].node="control"
nodetemplates[0].template="template_uuid" nodetemplates[1].node="worker" nodetemplates[1].template="template_uuid1"

[chunkyen]

Thank you @Pearl1594 perhaps we can look at include these as examples in the API documentation

[DaanHoogland]

@chunkyen , can you make a sugestion/PR to where/how to add it?

[chunkyen]

Thanks DaanHoogland, I would be happy to but I am new to this Open Source contribution thing. Maybe can you point me to a guide on how to make changes to https://cloudstack.apache.org/api/.
Specifically, I would want to add additional description to the description of createKubernetesCluster api parameters nodeofferings and nodetemplates to provide actual example of the syntax like what was provided by Pearl1594 above. The current documentation is not detail enough.

[DaanHoogland]

ok, the main procedure is not ACS specific but generic for github hosted projects.
the preferred way (not the simplest) is

1. fork the repository
2. checkout your fork
3. create a branch for your change (e.g. createK8sClusterApiDoc)
4. edit the file you want changed (in your case CreateKubernetesClusterCmd.java)
5. checking your changes
6. push the new branch to your fork
7. create a Pull Request to merge your branch on your fork unto the branch in the apache org it was branched off.
8. have people review it

alternatively, give us (/me and @Pearl1594 ) the text you want ;) and hope we have time to do that ^.