diff --git a/packages/api-fetch/src/middlewares/test/preloading.ts b/packages/api-fetch/src/middlewares/test/preloading.ts index 96352f60250db4..c00e957383f5e8 100644 --- a/packages/api-fetch/src/middlewares/test/preloading.ts +++ b/packages/api-fetch/src/middlewares/test/preloading.ts @@ -101,12 +101,12 @@ describe( 'Preloading Middleware', () => { const noResponseMock = 'undefined' === typeof window.Response; if ( noResponseMock ) { - // @ts-expect-error + // @ts-expect-error The stub does not implement the full `Response` static side. window.Response = class { constructor( body, options ) { - // @ts-expect-error + // @ts-expect-error `body` is not a declared property on the stub. this.body = JSON.parse( body ); - // @ts-expect-error + // @ts-expect-error `headers` is not a declared property on the stub. this.headers = options.headers; } }; @@ -141,7 +141,7 @@ describe( 'Preloading Middleware', () => { async () => {} ); if ( noResponseMock ) { - // @ts-expect-error + // @ts-expect-error The operand of `delete` must be optional. delete window.Response; } return response.then( ( value ) => { diff --git a/packages/blocks/src/api/matchers.ts b/packages/blocks/src/api/matchers.ts index 8b35d28f4ecb98..9c588dbc285845 100644 --- a/packages/blocks/src/api/matchers.ts +++ b/packages/blocks/src/api/matchers.ts @@ -1,7 +1,7 @@ /** * External dependencies */ -// @ts-ignore +// @ts-expect-error `hpq` does not ship type declarations. export { attr, prop, text, query } from 'hpq'; /** diff --git a/packages/blocks/src/api/parser/get-block-attributes.ts b/packages/blocks/src/api/parser/get-block-attributes.ts index 8cc4ddbebe4eb5..33c5c74650471b 100644 --- a/packages/blocks/src/api/parser/get-block-attributes.ts +++ b/packages/blocks/src/api/parser/get-block-attributes.ts @@ -1,7 +1,7 @@ /** * External dependencies */ -// @ts-ignore +// @ts-expect-error `hpq` does not ship type declarations. import { parse as hpqParse } from 'hpq'; import memoize from 'memize'; diff --git a/packages/blocks/src/store/process-block-type.ts b/packages/blocks/src/store/process-block-type.ts index caedcf825b32c6..6a99d1852fa42c 100644 --- a/packages/blocks/src/store/process-block-type.ts +++ b/packages/blocks/src/store/process-block-type.ts @@ -1,9 +1,8 @@ /** * External dependencies */ -// @ts-ignore -- No declaration file available. +// @ts-expect-error -- Its declaration file is not exposed through the `exports` map. import { isPlainObject } from 'is-plain-object'; -// @ts-ignore -- No declaration file available. import { isValidElementType } from 'react-is'; /** diff --git a/packages/boot/src/components/navigation/drilldown-item/index.tsx b/packages/boot/src/components/navigation/drilldown-item/index.tsx index 294a9c8ab2d96d..9561e6e44ea1f7 100644 --- a/packages/boot/src/components/navigation/drilldown-item/index.tsx +++ b/packages/boot/src/components/navigation/drilldown-item/index.tsx @@ -10,7 +10,6 @@ import type { ReactNode } from 'react'; import { FlexBlock, __experimentalItem as Item, - // @ts-ignore __experimentalHStack as HStack, Icon as WCIcon, } from '@wordpress/components'; diff --git a/packages/boot/src/components/navigation/dropdown-item/index.tsx b/packages/boot/src/components/navigation/dropdown-item/index.tsx index 581173358e0c5f..07c05755375806 100644 --- a/packages/boot/src/components/navigation/dropdown-item/index.tsx +++ b/packages/boot/src/components/navigation/dropdown-item/index.tsx @@ -10,7 +10,6 @@ import type { ReactNode } from 'react'; import { FlexBlock, __experimentalItem as Item, - // @ts-ignore __experimentalHStack as HStack, Icon as WCIcon, __unstableMotion as motion, @@ -72,7 +71,7 @@ export default function DropdownItem( { }: DropdownItemProps ) { const menuItems: MenuItem[] = useSelect( ( select ) => - // @ts-ignore + // @ts-expect-error Store types are not available when selecting by store name. select( STORE_NAME ).getMenuItems(), [] ); diff --git a/packages/boot/src/components/navigation/index.tsx b/packages/boot/src/components/navigation/index.tsx index b903ca0ace3c93..3b38ae7bd95c6b 100644 --- a/packages/boot/src/components/navigation/index.tsx +++ b/packages/boot/src/components/navigation/index.tsx @@ -24,7 +24,7 @@ function Navigation() { useSidebarParent(); const menuItems = useSelect( ( select ) => - // @ts-ignore + // @ts-expect-error Store types are not available when selecting by store name. select( STORE_NAME ).getMenuItems() as MenuItem[], [] ); diff --git a/packages/boot/src/components/navigation/navigation-item/index.tsx b/packages/boot/src/components/navigation/navigation-item/index.tsx index f353f249068045..a0b0a2b53adae3 100644 --- a/packages/boot/src/components/navigation/navigation-item/index.tsx +++ b/packages/boot/src/components/navigation/navigation-item/index.tsx @@ -10,7 +10,6 @@ import type { ReactNode } from 'react'; import { FlexBlock, __experimentalItem as Item, - // @ts-ignore __experimentalHStack as HStack, } from '@wordpress/components'; diff --git a/packages/boot/src/components/navigation/use-sidebar-parent.ts b/packages/boot/src/components/navigation/use-sidebar-parent.ts index e8bbf4ce1cb361..1f0c6099917f33 100644 --- a/packages/boot/src/components/navigation/use-sidebar-parent.ts +++ b/packages/boot/src/components/navigation/use-sidebar-parent.ts @@ -37,7 +37,7 @@ export function useSidebarParent() { const router = useRouter(); const menuItems = useSelect( ( select ) => - // @ts-ignore + // @ts-expect-error Store types are not available when selecting by store name. select( STORE_NAME ).getMenuItems(), [] ); diff --git a/packages/components/src/border-box-control/test/utils.ts b/packages/components/src/border-box-control/test/utils.ts index 03fd7be1420f48..37be048f375234 100644 --- a/packages/components/src/border-box-control/test/utils.ts +++ b/packages/components/src/border-box-control/test/utils.ts @@ -47,15 +47,13 @@ describe( 'BorderBoxControl Utils', () => { describe( 'isEmptyBorder', () => { it( 'should determine a undefined, null, and {} to be empty', () => { expect( isEmptyBorder( undefined ) ).toBe( true ); - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `null` is outside the declared `Border | undefined` input; resilience is tested. expect( isEmptyBorder( null ) ).toBe( true ); expect( isEmptyBorder( {} ) ).toBe( true ); } ); it( 'should determine object missing all border props to be empty', () => { - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `nonBorder` has no properties in common with `Border`; resilience is tested. expect( isEmptyBorder( nonBorder ) ).toBe( true ); } ); @@ -114,15 +112,13 @@ describe( 'BorderBoxControl Utils', () => { describe( 'isCompleteBorder', () => { it( 'should determine a undefined, null, and {} to be incomplete', () => { expect( isCompleteBorder( undefined ) ).toBe( false ); - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `null` is outside the declared `Border | undefined` input; resilience is tested. expect( isCompleteBorder( null ) ).toBe( false ); expect( isCompleteBorder( {} ) ).toBe( false ); } ); it( 'should determine objects missing border props to be incomplete', () => { - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `nonBorder` has no properties in common with `Border`; resilience is tested. expect( isCompleteBorder( nonBorder ) ).toBe( false ); expect( isCompleteBorder( partialBorder ) ).toBe( false ); expect( isCompleteBorder( partialWithExtraProp ) ).toBe( false ); @@ -157,8 +153,7 @@ describe( 'BorderBoxControl Utils', () => { it( 'should determine undefined, non-border or empty object as not being mixed', () => { expect( hasMixedBorders( undefined ) ).toBe( false ); expect( hasMixedBorders( {} ) ).toBe( false ); - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `nonBorder` is not assignable to `AnyBorder`; resilience is tested. expect( hasMixedBorders( nonBorder ) ).toBe( false ); } ); @@ -178,15 +173,13 @@ describe( 'BorderBoxControl Utils', () => { describe( 'getSplitBorders', () => { it( 'should return undefined when no border provided', () => { expect( getSplitBorders( undefined ) ).toEqual( undefined ); - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `null` is outside the declared `Border | undefined` input; resilience is tested. expect( getSplitBorders( null ) ).toEqual( undefined ); } ); it( 'should return undefined when supplied border is empty', () => { expect( getSplitBorders( {} ) ).toEqual( undefined ); - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `nonBorder` has no properties in common with `Border`; resilience is tested. expect( getSplitBorders( nonBorder ) ).toEqual( undefined ); } ); @@ -207,8 +200,7 @@ describe( 'BorderBoxControl Utils', () => { } ); it( 'should only return differences for border related properties', () => { - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `nonBorder` has no properties in common with `Border`; resilience is tested. const diff = getBorderDiff( nonBorder, { caffeine: 'coffee' } ); expect( diff ).toEqual( {} ); } ); @@ -217,8 +209,7 @@ describe( 'BorderBoxControl Utils', () => { const diff = getBorderDiff( completeBorder, { ...completeBorder, color: '#21759b', - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `caffeine` is not a declared `Border` property; the test checks it is ignored. caffeine: 'cola', } ); expect( diff ).toEqual( { color: '#21759b' } ); @@ -316,8 +307,7 @@ describe( 'BorderBoxControl Utils', () => { it( 'should return undefined when no border provided', () => { expect( getShorthandBorderStyle( undefined ) ).toEqual( undefined ); expect( getShorthandBorderStyle( {} ) ).toEqual( undefined ); - // Checking for extra resilience, even if not a valid type. - // @ts-expect-error + // @ts-expect-error `nonBorder` has no properties in common with `Border`; resilience is tested. expect( getShorthandBorderStyle( nonBorder ) ).toEqual( undefined ); } ); diff --git a/packages/components/src/button/test/index.tsx b/packages/components/src/button/test/index.tsx index 6167d4a6daa3a1..7a3e7a1a102b4a 100644 --- a/packages/components/src/button/test/index.tsx +++ b/packages/components/src/button/test/index.tsx @@ -2,6 +2,7 @@ * External dependencies */ import { render, screen } from '@testing-library/react'; +import { press } from '@ariakit/test'; /** * WordPress dependencies @@ -15,7 +16,6 @@ import { plusCircle } from '@wordpress/icons'; import _Button from '..'; import Tooltip from '../../tooltip'; import cleanupTooltip from '../../tooltip/test/utils'; -import { press } from '@ariakit/test'; jest.mock( '../../icon', () => () =>
); @@ -636,9 +636,9 @@ describe( 'Button', () => {