Merge pull request #1028 from Seagate/bugfix/fix-failing-azure-tests-with-new-azurite-version

Fix failing azurite tests

Author: jfantinhardesty

.github/workflows/unit-test.yml

@@ -61,6 +61,8 @@ jobs:
 
       azurite:
         image: mcr.microsoft.com/azure-storage/azurite:latest
+        env:
+          AZURITE_SKIP_API_VERSION_CHECK: "true"
         ports:
           - 10000:10000
           - 10001:10001

component/azstorage/block_blob.go

@@ -1271,13 +1271,13 @@ func (bb *BlockBlob) WriteFromFile(
 	// Compute md5 of this file is requested by user
 	// If file is uploaded in one shot (no blocks created) then server is populating md5 on upload automatically.
 	// hence we take cost of calculating md5 only for files which are bigger in size and which will be converted to blocks.
-	md5sum := []byte{}
+	var md5sum []byte
 	if bb.Config.updateMD5 && stat.Size() >= blockblob.MaxUploadBlobBytes {
 		md5sum, err = common.GetMD5(fi)
 		if err != nil {
 			// Md5 sum generation failed so set nil while uploading
 			log.Warn("BlockBlob::WriteFromFile : Failed to generate md5 of %s", name)
-			md5sum = []byte{0}
+			md5sum = nil
 		}
 	}
 

component/azstorage/block_blob_test.go

@@ -3892,11 +3892,14 @@ func (s *blockBlobTestSuite) TestInvalidateMD5PostUpload() {
 			s.assert.NoError(err)
 
 			blobClient := s.containerClient.NewBlobClient(name)
-			_, _ = blobClient.SetHTTPHeaders(
+			_, err = blobClient.SetHTTPHeaders(
 				context.Background(),
-				blob.HTTPHeaders{BlobContentMD5: []byte("cloudfuse")},
+				blob.HTTPHeaders{
+					BlobContentMD5: []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15},
+				},
 				nil,
 			)
+			s.assert.NoError(err)
 
 			prop, err := s.az.storage.GetAttr(ctx, name)
 			s.assert.NoError(err)
@@ -4096,11 +4099,14 @@ func (s *blockBlobTestSuite) TestInvalidMD5OnRead() {
 			_ = os.Remove(name)
 
 			blobClient := s.containerClient.NewBlobClient(name)
-			_, _ = blobClient.SetHTTPHeaders(
+			_, err = blobClient.SetHTTPHeaders(
 				context.Background(),
-				blob.HTTPHeaders{BlobContentMD5: []byte("cloudfuse")},
+				blob.HTTPHeaders{
+					BlobContentMD5: []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15},
+				},
 				nil,
 			)
+			s.assert.NoError(err)
 
 			prop, err := s.az.storage.GetAttr(ctx, name)
 			s.assert.NoError(err)
@@ -4170,11 +4176,14 @@ func (s *blockBlobTestSuite) TestInvalidMD5OnReadNoVaildate() {
 			_ = os.Remove(name)
 
 			blobClient := s.containerClient.NewBlobClient(name)
-			_, _ = blobClient.SetHTTPHeaders(
+			_, err = blobClient.SetHTTPHeaders(
 				context.Background(),
-				blob.HTTPHeaders{BlobContentMD5: []byte("cloudfuse")},
+				blob.HTTPHeaders{
+					BlobContentMD5: []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15},
+				},
 				nil,
 			)
+			s.assert.NoError(err)
 
 			prop, err := s.az.storage.GetAttr(ctx, name)
 			s.assert.NoError(err)