diff --git a/product_alias_multi_link/README.rst b/product_alias_multi_link/README.rst new file mode 100644 index 0000000000..685c7bbae8 --- /dev/null +++ b/product_alias_multi_link/README.rst @@ -0,0 +1,76 @@ +=========================== +Product Multi Links (Alias) +=========================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:ddf35c12f07cae4e2a5a9e8c9c1f4ded8355d2fd623484f854b033b52ceba29c + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fe--commerce-lightgray.png?logo=github + :target: https://github.com/OCA/e-commerce/tree/18.0/product_alias_multi_link + :alt: OCA/e-commerce +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-product_alias_multi_link + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/e-commerce&target_branch=18.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +Extends product links to support linking products through their aliases. + +**Table of contents** + +.. contents:: + :local: + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Akretion + +Contributors +------------ + +- Florian Mounier + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/e-commerce `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/product_alias_multi_link/__init__.py b/product_alias_multi_link/__init__.py new file mode 100644 index 0000000000..0650744f6b --- /dev/null +++ b/product_alias_multi_link/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/product_alias_multi_link/__manifest__.py b/product_alias_multi_link/__manifest__.py new file mode 100644 index 0000000000..8b11f4d2e1 --- /dev/null +++ b/product_alias_multi_link/__manifest__.py @@ -0,0 +1,20 @@ +# Copyright 2025 Akretion (http://www.akretion.com). +# @author Florian Mounier +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +{ + "name": "Product Multi Links (Alias)", + "version": "18.0.1.0.0", + "author": "Akretion, Odoo Community Association (OCA)", + "website": "https://github.com/OCA/e-commerce", + "license": "AGPL-3", + "depends": [ + # OCA/e-commerce + "product_alias", + "product_variant_multi_link", + ], + "data": [ + "views/product_template_link_view.xml", + ], + "installable": True, +} diff --git a/product_alias_multi_link/models/__init__.py b/product_alias_multi_link/models/__init__.py new file mode 100644 index 0000000000..55277b269e --- /dev/null +++ b/product_alias_multi_link/models/__init__.py @@ -0,0 +1,2 @@ +from . import product_alias +from . import product_template_link diff --git a/product_alias_multi_link/models/product_alias.py b/product_alias_multi_link/models/product_alias.py new file mode 100644 index 0000000000..f2c4aef55b --- /dev/null +++ b/product_alias_multi_link/models/product_alias.py @@ -0,0 +1,28 @@ +# Copyright 2025 Akretion (http://www.akretion.com). +# @author Florian Mounier +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo import fields, models + + +class ProductAlias(models.Model): + _inherit = "product.alias" + + product_alias_link_ids = fields.One2many( + string="Product Alias Links", + comodel_name="product.template.link", + compute="_compute_product_link_ids", + ) + + def _compute_product_link_ids(self): + for record in self: + record.product_alias_link_ids = record._get_alias_links() + + def _get_alias_links(self): + return self.env["product.template.link"].search( + [ + "|", + ("left_product_alias_id", "=", self.id), + ("right_product_alias_id", "=", self.id), + ] + ) diff --git a/product_alias_multi_link/models/product_template_link.py b/product_alias_multi_link/models/product_template_link.py new file mode 100644 index 0000000000..159237bb04 --- /dev/null +++ b/product_alias_multi_link/models/product_template_link.py @@ -0,0 +1,72 @@ +# Copyright 2025 Akretion (http://www.akretion.com). +# @author Florian Mounier +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo import api, fields, models + + +class ProductTemplateLink(models.Model): + _inherit = "product.template.link" + + left_product_alias_id = fields.Many2one( + string="Source Alias", + comodel_name="product.alias", + ondelete="cascade", + ) + right_product_alias_id = fields.Many2one( + string="Linked Alias", + comodel_name="product.alias", + ondelete="cascade", + ) + + def _product_variant_check_enabled(self): + # Do not force alias or variants, do with what you have + return False + + @api.constrains( + "left_product_tmpl_id", + "right_product_tmpl_id", + "type_id", + "left_product_id", + "right_product_id", + "left_product_alias_id", + "right_product_alias_id", + ) + def _check_products(self): + return super()._check_products() + + def _check_product_not_different(self): + res = super()._check_product_not_different() + # Link is identical if everything is the same + return ( + res + and self.left_product_id == self.right_product_id + and self.left_product_alias_id == self.right_product_alias_id + ) + + def _check_products_query_params(self): + params = super()._check_products_query_params() + # Link is identical if everything is the same on both sides + params["main_select_columns"] += ( + ", right_product_id, left_product_id" + ", right_product_alias_id, left_product_alias_id" + ) + # Use "is not distinct from" to handle NULL values + params["l2_join_where_clause"] += """ + AND right_product_id is not distinct from l1.left_product_id + AND left_product_id is not distinct from l1.right_product_id + AND right_product_alias_id is not distinct from l1.left_product_alias_id + AND left_product_alias_id is not distinct from l1.right_product_alias_id + """ + params["l3_join_where_clause"] += """ + AND left_product_id is not distinct from l1.left_product_id + AND right_product_id is not distinct from l1.right_product_id + AND left_product_alias_id is not distinct from l1.left_product_alias_id + AND right_product_alias_id is not distinct from l1.right_product_alias_id + """ + return params + + def _invalidate_links(self): + res = super()._invalidate_links() + self.env["product.alias"].invalidate_model(["product_alias_link_ids"]) + return res diff --git a/product_alias_multi_link/pyproject.toml b/product_alias_multi_link/pyproject.toml new file mode 100644 index 0000000000..4231d0cccb --- /dev/null +++ b/product_alias_multi_link/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/product_alias_multi_link/readme/CONTRIBUTORS.md b/product_alias_multi_link/readme/CONTRIBUTORS.md new file mode 100644 index 0000000000..39765eecb6 --- /dev/null +++ b/product_alias_multi_link/readme/CONTRIBUTORS.md @@ -0,0 +1 @@ +- Florian Mounier \ diff --git a/product_alias_multi_link/readme/DESCRIPTION.md b/product_alias_multi_link/readme/DESCRIPTION.md new file mode 100644 index 0000000000..a206c7227b --- /dev/null +++ b/product_alias_multi_link/readme/DESCRIPTION.md @@ -0,0 +1 @@ +Extends product links to support linking products through their aliases. diff --git a/product_alias_multi_link/static/description/index.html b/product_alias_multi_link/static/description/index.html new file mode 100644 index 0000000000..6f67974793 --- /dev/null +++ b/product_alias_multi_link/static/description/index.html @@ -0,0 +1,423 @@ + + + + + +Product Multi Links (Alias) + + + + + + diff --git a/product_alias_multi_link/tests/__init__.py b/product_alias_multi_link/tests/__init__.py new file mode 100644 index 0000000000..f96faf7f34 --- /dev/null +++ b/product_alias_multi_link/tests/__init__.py @@ -0,0 +1 @@ +from . import test_product_alias_multi_link diff --git a/product_alias_multi_link/tests/test_product_alias_multi_link.py b/product_alias_multi_link/tests/test_product_alias_multi_link.py new file mode 100644 index 0000000000..8dff09c26d --- /dev/null +++ b/product_alias_multi_link/tests/test_product_alias_multi_link.py @@ -0,0 +1,280 @@ +# Copyright 2025 Akretion (http://www.akretion.com). +# @author Sébastien Alix +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo.exceptions import ValidationError + +from odoo.addons.base.tests.common import BaseCommon + + +class TestProductAliasMultiLink(BaseCommon): + """Test product template links with alias support""" + + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.ProductTemplateLink = cls.env["product.template.link"] + cls.ProductAlias = cls.env["product.alias"] + cls.ProductTemplate = cls.env["product.template"] + # Get test products + cls.product_product_1 = cls.env.ref("product.product_product_1") + cls.product_product_2 = cls.env.ref("product.product_product_2") + cls.product_tmpl_1 = cls.product_product_1.product_tmpl_id + cls.product_tmpl_2 = cls.product_product_2.product_tmpl_id + # Get test link type + cls.link_type = cls.env.ref( + "product_template_multi_link.product_template_link_type_cross_selling" + ) + # Get attributes for product_product_4 + cls.tmpl_with_attrs = cls.env.ref("product.product_product_4_product_template") + cls.product_sw = cls.env.ref("product.product_product_4") # steel, white + cls.product_sb = cls.env.ref("product.product_product_4b") # steel, black + cls.product_aw = cls.env.ref("product.product_product_4c") # aluminium, white + cls.attr_a = cls.env.ref("product.product_attribute_value_2") # aluminium + cls.attr_s = cls.env.ref("product.product_attribute_value_1") # steel + cls.attr_w = cls.env.ref("product.product_attribute_value_3") # white + + def _create_link_with_aliases( + self, + left_tmpl, + left_alias, + right_tmpl, + right_alias, + left_prod=None, + right_prod=None, + ): + """Helper to create a link with aliases""" + values = { + "left_product_tmpl_id": left_tmpl.id, + "left_product_alias_id": left_alias.id, + "right_product_tmpl_id": right_tmpl.id, + "right_product_alias_id": right_alias.id, + "type_id": self.link_type.id, + } + if left_prod: + values["left_product_id"] = left_prod.id + if right_prod: + values["right_product_id"] = right_prod.id + link = self.ProductTemplateLink.create(values) + link.flush_recordset() + return link + + def test_create_link_with_aliases_only(self): + """ + Data: + - 2 product templates with aliases + Test Case: + - Create a link between two aliases + Expected result: + - Link is created successfully + """ + # Create aliases + alias_a = self.ProductAlias.create( + { + "name": "Aluminium Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_a.id])], + } + ) + alias_s = self.ProductAlias.create( + { + "name": "Steel Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_s.id])], + } + ) + # Create a link with aliases only (no error) + self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_a, + self.tmpl_with_attrs, + alias_s, + ) + + def test_create_link_with_products_and_aliases(self): + """ + Data: + - 2 product templates + - Products with associated aliases + Test Case: + - Create a link with both products and aliases + Expected result: + - Link is created with all fields populated + """ + # Create aliases + alias_a = self.ProductAlias.create( + { + "name": "Aluminium Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_a.id])], + } + ) + alias_s = self.ProductAlias.create( + { + "name": "Steel Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_s.id])], + } + ) + # Create a link with products and aliases (no error) + self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_a, + self.tmpl_with_attrs, + alias_s, + left_prod=self.product_aw, + right_prod=self.product_sw, + ) + + def test_identical_link_with_aliases_rejected(self): + """ + Data: + - 2 product templates with aliases + Test Case: + - Create a link between two aliases + - Try to create the same link with aliases + Expected result: + - ValidationError is raised for identical link + """ + # Create aliases + alias_a = self.ProductAlias.create( + { + "name": "Aluminium Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_a.id])], + } + ) + alias_s = self.ProductAlias.create( + { + "name": "Steel Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_s.id])], + } + ) + # Create first link + link = self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_a, + self.tmpl_with_attrs, + alias_s, + ) + # Try to copy link (should fail as it creates a duplicate) + with self.assertRaises(ValidationError), self.env.cr.savepoint(): + link.copy() + + def test_inverse_link_with_aliases_rejected(self): + """ + Data: + - 2 product templates with aliases + Test Case: + - Create a link between alias_a -> alias_s + - Try to create inverse link alias_s -> alias_a + Expected result: + - ValidationError is raised for inverse link + """ + # Create aliases + alias_a = self.ProductAlias.create( + { + "name": "Aluminium Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_a.id])], + } + ) + alias_s = self.ProductAlias.create( + { + "name": "Steel Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_s.id])], + } + ) + # Create first link + self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_a, + self.tmpl_with_attrs, + alias_s, + ) + # Try to create inverse link + with self.assertRaises(ValidationError), self.env.cr.savepoint(): + self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_s, + self.tmpl_with_attrs, + alias_a, + ) + + def test_alias_link_ids_both_sides(self): + """ + Data: + - Two aliases (A, B) + Test Case: + - Create link A->B + - Get product_alias_link_ids from both aliases + Expected result: + - Both aliases see the same link in their computed field + """ + alias_a = self.ProductAlias.create( + { + "name": "Aluminium", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_a.id])], + } + ) + alias_s = self.ProductAlias.create( + { + "name": "Steel", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_s.id])], + } + ) + link = self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_a, + self.tmpl_with_attrs, + alias_s, + ) + # Both aliases should see the link + self.assertIn(link, alias_a.product_alias_link_ids) + self.assertIn(link, alias_s.product_alias_link_ids) + + def test_link_cache_invalidation_on_unlink(self): + """ + Data: + - 2 product templates with aliases + Test Case: + - Create a link between two aliases + - Verify aliases have the link in their computed field + - Unlink the link + Expected result: + - Aliases' product_alias_link_ids cache is invalidated + """ + # Create aliases + alias_a = self.ProductAlias.create( + { + "name": "Aluminium Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_a.id])], + } + ) + alias_s = self.ProductAlias.create( + { + "name": "Steel Variant", + "product_tmpl_id": self.tmpl_with_attrs.id, + "attribute_value_ids": [(6, 0, [self.attr_s.id])], + } + ) + # Create link + link = self._create_link_with_aliases( + self.tmpl_with_attrs, + alias_a, + self.tmpl_with_attrs, + alias_s, + ) + # Verify link is in aliases' computed field + self.assertIn(link, alias_a.product_alias_link_ids) + self.assertIn(link, alias_s.product_alias_link_ids) + # Unlink the link (cache should be invalidated) + link.unlink() + # Verify link is removed from aliases' computed field + self.assertNotIn(link, alias_a.product_alias_link_ids) + self.assertNotIn(link, alias_s.product_alias_link_ids) diff --git a/product_alias_multi_link/views/product_template_link_view.xml b/product_alias_multi_link/views/product_template_link_view.xml new file mode 100644 index 0000000000..1c34a3fba5 --- /dev/null +++ b/product_alias_multi_link/views/product_template_link_view.xml @@ -0,0 +1,127 @@ + + + + + product.template.link + + + + + + + + + product.template.link + + + + + + + + + + + + + [('product_tmpl_id', '=', left_product_tmpl_id), + ('alias_id', '=?', left_product_alias_id)] + + + [('product_tmpl_id', '=', right_product_tmpl_id), + ('alias_id', '=?', right_product_alias_id)] + + + + + product.template.link + + + + + + + + + + [('product_tmpl_id', '=', left_product_tmpl_id), + ('alias_id', '=?', left_product_alias_id)] + + + [('product_tmpl_id', '=', right_product_tmpl_id), + ('alias_id', '=?', right_product_alias_id)] + + + + + product.template.link + + + + + + + + + + [('product_tmpl_id', '=', left_product_tmpl_id), ('alias_id', '=?', left_product_alias_id)] + + + [('product_tmpl_id', '=', right_product_tmpl_id), ('alias_id', '=?', right_product_alias_id)] + + + + diff --git a/test-requirements.txt b/test-requirements.txt new file mode 100644 index 0000000000..37f7583b3a --- /dev/null +++ b/test-requirements.txt @@ -0,0 +1 @@ +odoo-addon-product_alias @ git+https://github.com/OCA/e-commerce.git@refs/pull/1206/head#subdirectory=product_alias