Point the download job at test_download.py, and trim the import test

download-test.yml ran `pytest ... download.py` from moabb/tests. That file
does not exist -- it is test_download.py -- so pytest exited 4 and the job has
failed every month since at least March while no @pytest.mark.download test
ran anywhere in CI. The corrected path collects 537 tests.

Also trims the new import side-effect test from 78 to 59 lines: the
theme-is-still-applied assertion belongs with the leak assertion it qualifies.

Author: bruAristimunha

.github/workflows/download-test.yml

@@ -38,5 +38,4 @@ jobs:
       - name: Run download tests
         run: |
           echo "Running tests"
-          cd moabb/tests
-          pytest -vv -s --tb=long --durations=0 --maxfail=5 --log-cli-level=INFO --dl-data download.py
+          pytest -vv -s --tb=long --durations=0 --maxfail=5 --log-cli-level=INFO --dl-data moabb/tests/test_download.py

docs/source/whats_new.rst

@@ -35,6 +35,7 @@ Requirements
 
 Bugs
 ~~~~
+- Point the monthly download job at ``moabb/tests/test_download.py``; it ran ``download.py``, a file that does not exist, so it collected nothing and has been failing every month while no ``@pytest.mark.download`` test executed anywhere in CI (by `Bruno Aristimunha`_).
 - Stop importing moabb from restyling the caller's matplotlib. ``moabb.analysis.plotting`` applies a seaborn theme to the global ``rcParams`` when it is imported, and three separate chains reached it eagerly, so ``import moabb.datasets`` alone changed ``font.family``, ``axes.grid`` and ``axes.spines.*`` for every figure the caller drew afterwards -- values matplotlib reads at axes creation, so they cannot be undone after the fact. The chain that mattered was indirect: :mod:`moabb.datasets.bids_interface` imports ``moabb.analysis.results`` for ``get_digest``, which ran ``moabb/analysis/__init__.py``, which imported ``plotting``. Those imports are now deferred to the functions that use them and to module-level ``__getattr__`` (:pep:`562`), so every public name still resolves -- ``dir()`` and Sphinx autodoc included -- and an explicit ``import moabb.analysis.plotting`` still applies the theme, leaving MOABB's own figures unchanged. ``import moabb`` also drops from about 2.6 s to 0.2 s (by `Bruno Aristimunha`_).
 - Type the seven non-EEG channels of :class:`moabb.datasets.BNCI2025_001` as ``misc``. ``read_raw_eeglab`` types anything it does not recognise as ``eeg``, so ``x``/``y``/``vx``/``vy``/``validity``/``targetPosX``/``targetPoxY`` -- the hand kinematics and the target position of the reaching task -- were picked as EEG by every paradigm and fed to classifiers as features, leaking the labels they encode. The declared ``n_channels`` (67) also disagreed with the dataset's own 60-electrode montage; it is now 71 with ``channel_types={"eeg": 60, "eog": 4, "misc": 7}``. Accuracies on this dataset will fall, which is the point (by `Bruno Aristimunha`_).
 - Give :class:`moabb.datasets.Rodrigues2017` the montage :gh:`700` announced but never shipped, the same omission as :class:`moabb.datasets.Cattan2019_PHMD` below: both share the 16-electrode setup, both spelled ``Fc5``/``Fc6`` -- the only two names ``standard_1020`` cannot resolve -- and neither loader called ``set_montage``. Its ``METADATA`` also declared ``standard_1010``, which is not a montage MNE can build (by `Bruno Aristimunha`_).

moabb/tests/test_import_side_effects.py

@@ -1,78 +1,59 @@
-"""Importing moabb must not touch the caller's global state.
+"""Importing moabb must not restyle the caller's matplotlib.
 
-``moabb.analysis.plotting`` applies a seaborn theme to matplotlib's global
-rcParams at import time. That is fine for someone who asked for plotting, but
-it used to reach anyone who merely imported a dataset: ``moabb.datasets``
-imports ``moabb.analysis.results`` for ``get_digest``, which ran
-``moabb/analysis/__init__.py``, which imported ``plotting`` eagerly.
+``moabb.analysis.plotting`` themes the global rcParams at import time. That is
+fine for someone who asked for plotting, but it used to reach anyone who merely
+imported a dataset, via ``moabb.datasets.bids_interface`` -> ``analysis.results``.
 """
 
+import json
 import subprocess
 import sys
 
+import pytest
 
-# Read at figure/axes creation, so a caller cannot undo them after the fact.
-_WATCHED = ("font.family", "axes.grid", "axes.spines.left", "axes.spines.top")
+
+# Read at axes creation, so a caller cannot undo them afterwards.
+_WATCHED = ("font.family", "axes.grid", "axes.spines.left")
 
 _PROBE = """
-import json, sys
-import matplotlib
+import json, sys, matplotlib
 matplotlib.use("Agg")
 import matplotlib.pyplot as plt
-
-watched = {watched!r}
-before = {{k: repr(plt.rcParams[k]) for k in watched}}
+before = {{k: repr(plt.rcParams[k]) for k in {watched!r}}}
 import {module}  # noqa: F401
-after = {{k: repr(plt.rcParams[k]) for k in watched}}
-json.dump({{"before": before, "after": after}}, sys.stdout)
+after = {{k: repr(plt.rcParams[k]) for k in {watched!r}}}
+json.dump([before, after], sys.stdout)
 """
 
 
-def _rcparams_around_import(module):
-    """Import ``module`` in a fresh interpreter, reporting rcParams either side."""
+def _around_import(module):
+    """rcParams before and after importing ``module`` in a fresh interpreter."""
     out = subprocess.run(
         [sys.executable, "-c", _PROBE.format(module=module, watched=_WATCHED)],
         capture_output=True,
         text=True,
         check=True,
     )
-    import json
-
     return json.loads(out.stdout)
 
 
 def test_importing_moabb_does_not_restyle_matplotlib():
-    for module in ("moabb", "moabb.datasets", "moabb.analysis", "moabb.paradigms"):
-        seen = _rcparams_around_import(module)
-        assert seen["before"] == seen["after"], (
-            f"import {module} mutated global rcParams: "
-            f"{seen['before']} -> {seen['after']}"
-        )
-
+    for module in ("moabb", "moabb.datasets", "moabb.analysis"):
+        before, after = _around_import(module)
+        assert before == after, f"import {module} mutated rcParams: {before} -> {after}"
 
-def test_plotting_still_applies_the_theme_when_asked_for():
-    """The theme must not be lost -- only stopped from leaking."""
-    seen = _rcparams_around_import("moabb.analysis.plotting")
-    assert seen["before"] != seen["after"]
+    # The theme must be kept, not lost -- only stopped from leaking.
+    before, after = _around_import("moabb.analysis.plotting")
+    assert before != after
 
 
 def test_lazily_exported_names_still_resolve():
     import moabb
     import moabb.analysis
 
-    assert callable(moabb.benchmark)
-    assert "benchmark" in dir(moabb)
+    assert callable(moabb.benchmark) and "benchmark" in dir(moabb)
     for name in ("codecarbon_plot", "distribution_plot", "emissions_summary"):
-        assert callable(getattr(moabb.analysis, name))
-        assert name in dir(moabb.analysis)
-
-
-def test_unknown_attribute_still_raises_attributeerror():
-    import moabb
+        assert callable(getattr(moabb.analysis, name)) and name in dir(moabb.analysis)
 
-    try:
-        moabb.definitely_not_a_real_attribute
-    except AttributeError as exc:
-        assert "definitely_not_a_real_attribute" in str(exc)
-    else:  # pragma: no cover
-        raise AssertionError("expected AttributeError")
+    with pytest.raises(AttributeError, match="definitely_not_real"):
+        _ = moabb.definitely_not_real