Skip to content

feat(ci): restore fork pull request support - #428

Draft
yashrajp22 wants to merge 1 commit into
mainfrom
yashraj/restore-fork-pull-request-support
Draft

feat(ci): restore fork pull request support#428
yashrajp22 wants to merge 1 commit into
mainfrom
yashraj/restore-fork-pull-request-support

Conversation

@yashrajp22

@yashrajp22 yashrajp22 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restores the fork pull request workflow changes from #416 after they were reverted by #422 while end-to-end testing was incomplete.

  • recognize generated signature commits only when their paths, title, and verified GitHub identity match policy
  • require validation evidence at or after the generated signature commit
  • bound required-status polling
  • skip redundant signature-push dispatch when no dispatch secret is available
  • give fork contributors service-account onboarding guidance

Dependencies

Keep this draft until both backend changes are ready:

  • NVIDIA/nvskills-ci#60
  • nvcarps-ci!201

Verification

Test-environment note

The initial /nvskills-ci caller resolved the requester and PR context, but its cross-repository dispatch returned HTTP 403 because the NVIDIA/nvskills-ci-test repository's stored NVSKILLS_CI_DISPATCH_TOKEN is stale or under-scoped. I reran the exact payload with current authenticated access to complete the backend smoke test. The same stale secret also leaves the optional signature-push request job red; the authoritative NVSkills CI status and required-status check are green on the generated head commit. Refresh that test-repository secret before the final exact comment-path smoke test.

Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant