pay: add missing deprecation annotation

- add missing deprecation annotation to "pay" command,
- fix tests that required allow-deprecated-apis=True in order to
continue using "pay",
- change "pay" to "xpay" in those tests that
are NOT testing "pay" directly but just want to make a payment,
- and in tests that could be relevant for both "xpay" and "pay", use
  both.

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

Author: Lagrang3

plugins/pay.c

@@ -1168,7 +1168,8 @@ static const struct plugin_command commands[] = {
 	},
 	{
 		"pay",
-		json_pay
+		json_pay,
+		"v26.06", "v27.03",
 	},
 };
 

tests/plugins/dynamic_clnrest_path.py

@@ -41,7 +41,7 @@ def init(options, configuration, plugin):
             "dynamic-clnrest-method",
             "POST",
             True,
-            {"method": "pay"},
+            {"method": "xpay"},
         ],
     )
     plugin.rpc.call(
@@ -51,7 +51,7 @@ def init(options, configuration, plugin):
             "dynamic-clnrest-method-2",
             "PATCH",
             True,
-            {"method": "pay"},
+            {"method": "xpay"},
         ],
     )
     plugin.rpc.call(
@@ -61,7 +61,7 @@ def init(options, configuration, plugin):
             "dynamic-clnrest-method",
             "DELETE",
             True,
-            {"method": "pay"},
+            {"method": "xpay"},
         ],
     )
     plugin.rpc.call(

tests/test_clnrest.py

@@ -422,7 +422,8 @@ def test_numeric_msat_notification(node_factory):
     # create rune authorizing listclnrest-notifications method
     rune_clnrest_notifications = l2.rpc.createrune(restrictions=[["method=listclnrest-notifications"]])['rune']
     http_session.headers.update({"rune": rune_clnrest_notifications})
-    notifications = notifications_received_via_websocket(l1, base_url, http_session, 'pay', [inv['bolt11']])
+    notifications = notifications_received_via_websocket(l1, base_url,
+                                                         http_session, 'xpay', [inv['bolt11']])
     filtered_notifications = [n for n in notifications if 'invoice_payment' in n]
 
     assert isinstance(filtered_notifications[0]['invoice_payment']['msat'], int)
@@ -875,7 +876,7 @@ def test_dynamic_path_rune(node_factory):
         dynamic_res.json()["message"] == "Not permitted: method is not equal to notpay"
     )
 
-    rune = l1.rpc.createrune(restrictions=[["method=pay"]])["rune"]
+    rune = l1.rpc.createrune(restrictions=[["method=xpay"]])["rune"]
     dynamic_res = http_session.post(
         base_url + "/test/dynamic/clnrest", headers={"Rune": rune}, verify=ca_cert
     )